Reversed Order of Personnel Logs, Renamed 'Personnel Log' to 'Personal Log' #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected spelling in PersonViewPanel properties from 'Personnel' to 'Personal' Log - Reversed the order of logs, scenario logs, and kill records for easier user readability
SJuliez
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverses the order of the three personnel logs (personal, scenarios, and kills) so that the order is newest to oldest; instead of oldest to newest. This will help reduce the amount of scrolling users need to do, whenever they're trying to review the personnel logs.
I also went ahead and renamed the 'personnel log' (the one that covers things like unit assignment, marriage, children, and injuries) to 'personal log'. This was a pet peeve of mine and I highly expect I am the only person bothered by this but having 'personnel logs' (as a collection of the three logs) and 'personnel log' (being only the personal log) made discussing the logs a right pain.
Closes
Partially addresses #2238 by reducing the amount of scrolling required.
Closes #4032