Tied StratCon Force Generation BV Allowance to AtB Difficulty Option #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why these changes weren't in the original Push
…sers to adjust their maximum number, appearance chance, and BV Cap values.
The function `setScenarioModifiers` and the method `generateForce` were updated. The former was adjusted to use a random number within a provided range, instead of a hardcoded value, when setting scenario modifiers. The latter was altered to use a boolean parameter, `isScenarioModifier`, allowing the method to distinguish if the force generation is triggered by a scenario modifier or not.
Changes mainly involve modifying whether a component contributes to the map size or battle value (BV), and also includes the addition of an override BV cap in some scenarios.
The BV Cap override check has been inverted in AtBDynamicScenarioFactory to handle cases where the scenario modifier is present. Now, when the override is true, a log message is printed and the BV budget is modified accordingly. This is intended to provide better logging and managing of BV Cap overrides.
This commit eliminates the possibility of an infinite loop when adding modifiers in the AtBDynamicScenarioFactory class. This is achieved by setting the 'addMods' flag to false when the conditional statement isn't met.
- Increased acceptable forceBV to 125% of forceBVBudget from 110%
IllianiCBT
added
AtB
StratCon
SJuliez
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, this PR multiplies the BV allowance, granted to opposition OpFors, to the AtB Difficulty campaign option using the below formula.
1 + ((skill level - 2) / 10)There are also a couple of whitespace removals in files I changed in #4104 (which this PR is branched from). I could have moved those to a separate PR, but it didn't seem worth it.
Closes
Partially closes #4011