Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Labels and Tooltips for Better Clarity and Grammar #4134

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Jun 3, 2024

  • Removed trailing dots for a cleaner GUI
  • Updated tooltips and text fields within a handful of ResourcesBundles
  • All text grammatically reviewed.
  • Removed a cuss from one of our in-code comments

- Removed trailing dots for a cleaner GUI
- Updated tooltips and text fields within a handful of ResourcesBundles
- All text grammatically reviewed.
@IllianiCBT IllianiCBT self-assigned this Jun 3, 2024
@IllianiCBT IllianiCBT added the GUI label Jun 3, 2024
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to note that trailing dots indicate that a menu option is not a direct action but opens a dialog to input further settings. So it is a valid design choice. I have no strong feelings on that so I'll leave it as a comment.

IntelliJ IDEA uses that:
image
So does Notepad++
image

@SJuliez
Copy link
Member

SJuliez commented Jun 6, 2024

Any thoughts on those dots?

@IllianiCBT
Copy link
Collaborator Author

Any thoughts on those dots?

Completely forgot to do this: all restored

@SJuliez SJuliez merged commit 8a44806 into MegaMek:master Jun 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants