Implemented Basic Tax System, Profits Calculations, and Minor Financial Term Changes #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed 'Financial Year' elements to 'Financial Term.' - Implemented tax calculation and payment method in Finances. - Added Taxes settings in CampaignOptions. - Created a new Taxes panel in the Finances tab. - Updated tooltips and labels related to finances and taxes. - Added the ability to exempt certain factions from taxes.
* Removed previousTermFiscalBalance related methods and variables * Updated getProfits() method to calculate profits based on transactions * Added a report string for profits in Finance.properties
SJuliez
approved these changes
Jun 4, 2024
# Conflicts: # MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties # MekHQ/resources/mekhq/resources/Finances.properties # MekHQ/src/mekhq/campaign/CampaignOptions.java # MekHQ/src/mekhq/campaign/finances/enums/TransactionType.java # MekHQ/src/mekhq/gui/panes/CampaignOptionsPane.java # MekHQ/unittests/mekhq/campaign/finances/enums/TransactionTypeTest.java
|
Resolved conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the financial management system by renaming 'Financial Year' elements to 'Financial Term' and introducing new tax-related features.
Key Changes
Renamed 'Financial Year' to 'Financial Term':
Implemented Tax Calculation and Payments:
TransactionTypeisSTARTING_CAPITALandFINANCIAL_TERM_END_CARRYOVER.Added Taxes Settings in Campaign Options:
Testing and Validation
Conclusion
This system introduces a financial challenge to help manage campaign growth, preventing players from becoming overpowered too quickly.
As a Brit, I expect these changes to be very popular among our player base. After all, when have people ever been upset over paying their taxes?