Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Education Module Bug Fixes #4114

Merged
merged 6 commits into from
May 29, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented May 26, 2024

This PR addresses a number of bugs that were picked up by QA.

  • Corrected faulty logic in Max Jump Count check
  • Fixed Max Jump Count setting failing to save user choices. This is why the above logic error went undetected.
  • Addressed users not understanding why Trueborn students only have a travel time of 2 days (via Campaign Option to enable/disable this)
  • Fixed formatting errors in clan washout text
  • Fixed missed course index assignment causing problems with clan graduation and (potentially) skill increases.

Each graduateCaste method in the EducationController has been adjusted to include a return statement following the method call, thereby preventing the execution of multiple graduateCaste calls within a single instance. The update ensures process efficiency and eliminates potential errors caused by unintended multiple gradations.
The commit changes the condition checking for maximum jump count in PersonnelTableMouseAdapter. Previously, the condition for simplified travel time was checking for less than or equal to the maximum jump count, which was incorrect. This has been corrected to greater than the maximum jump count to work as intended.
@IllianiCBT IllianiCBT self-assigned this May 26, 2024
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels May 26, 2024
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit de738f5 into MegaMek:master May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants