if planetary conditions are disabled in options don't send conditions … #4066

kuronekochomusuke · 2024-05-08T22:37:30Z

if planetary conditions are disabled in campaign options, don't send conditions to megamek

…to megemek

Sleet01 · 2024-05-08T23:02:42Z

Looks like testFactionBorderTrackerAllPlanets is failing, but only under Temurin 17; this usually indicates a spy or mock issue due to Java 17's more restrictive reflection rules.

One option is to rewrite the test, but the other is to annotate it to be ignored only under Temurin 17:

@DisabledForJreRange(min = JRE.JAVA_17, max = JRE.OTHER)

Sleet01

Looks good to me.

kuronekochomusuke added 2 commits May 8, 2024 18:35

if plantary conditions are disabled in options don't send conditions …

d5b066c

…to megemek

rename setWeather() to setWeatherConditions()

3a1f01c

Sleet01 approved these changes May 8, 2024

View reviewed changes

Sleet01 merged commit 33a36ea into MegaMek:master May 8, 2024
3 of 4 checks passed

kuronekochomusuke deleted the issue_4062 branch November 11, 2024 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

if planetary conditions are disabled in options don't send conditions … #4066

if planetary conditions are disabled in options don't send conditions … #4066

kuronekochomusuke commented May 8, 2024

Sleet01 commented May 8, 2024

Sleet01 left a comment

if planetary conditions are disabled in options don't send conditions … #4066

if planetary conditions are disabled in options don't send conditions … #4066

Conversation

kuronekochomusuke commented May 8, 2024

Sleet01 commented May 8, 2024

Sleet01 left a comment

Choose a reason for hiding this comment