Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MHQ #4002: prevent infinite loop while assigning SPAs by removing unusable entries #4009

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Apr 17, 2024

Note: this may fix #4002, or may only fix something that may be contributing to it.

Prevent infinite loop by reducing choices each time we continue the while loop.
Also remove a check for more elements in some SPAs that, honestly, I don't remember writing - it actively prevents some SPAs from being applied even if they are valid.

Testing:

Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixed the freeze I was getting following IllianiCBT's steps to reproduce the issue

@Sleet01 Sleet01 merged commit ac01416 into MegaMek:master Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

49.19 Nightly - Soft Freeze upon advancing day.
2 participants