Add disabled option for Personnel Market #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGullickson
added
the
(RFE) Enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3953 +/- ##
============================================
- Coverage 10.65% 10.65% -0.01%
Complexity 5528 5528
============================================
Files 836 838 +2
Lines 114275 114302 +27
Branches 17185 17190 +5
============================================
Hits 12176 12176
- Misses 100871 100898 +27
Partials 1228 1228 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For years, even aeons, MekHQ has included a personnel market that the user had no ability to disable, creating enormous frustration and breaking of immersion among those of who had no use for it. The unit market - you can disable it. The contract market - you can disable it. The personnel market - apparently it has been ordained by God.
But no longer! I bring good tidings. Despite an absolute byzantine coding scheme, I have managed against all odds in this PR to add a disabled option to the personnel market choices, without disrupting people's existing choices in saved games. Furthermore, if you choose disabled, you will not even be forced to look at the personnel market menu item. Hallelujah!