Variable OperationalVP Added to CommonObjectiveFactory.java #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3951 +/- ##
=========================================
Coverage 10.65% 10.65%
Complexity 5528 5528
=========================================
Files 836 836
Lines 114275 114275
Branches 17185 17185
=========================================
Hits 12176 12176
Misses 100871 100871
Partials 1228 1228 ☔ View full report in Codecov by Sentry. |
Sleet01
reviewed
Apr 3, 2024
MekHQ/src/mekhq/campaign/mission/atb/scenario/AlliedTraitorsBuiltInScenario.java
Outdated
Show resolved
Hide resolved
Sleet01
reviewed
Apr 3, 2024
MekHQ/src/mekhq/campaign/mission/atb/scenario/AceDuelBuiltInScenario.java
Outdated
Show resolved
Hide resolved
Sleet01
reviewed
Apr 3, 2024
MekHQ/src/mekhq/campaign/mission/atb/scenario/BaseAttackBuiltInScenario.java
Outdated
Show resolved
Hide resolved
Sleet01
reviewed
Apr 3, 2024
MekHQ/src/mekhq/campaign/mission/atb/scenario/ChaseBuiltInScenario.java
Outdated
Show resolved
Hide resolved
Sleet01
requested changes
Apr 3, 2024
Sleet01
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Implementation
MekHQ/src/mekhq/campaign/mission/CommonObjectiveFactory.javadetails the victory conditions (objectives) for the various built in AtB scenarios. All objectives have a fixed Operational Victory Point value of 1.Problem
This means that it is not possible to edit the value of objectives when compared to each other. For example, in one scenario you might have three objectives: 1 primary, 2 secondary. All objectives are valued identically, meaning completing both secondary objectives but losing the primary is still considered a victory.
Solution
I added the integer
OperationalVPto objective functions, where applicable. I updated all calls from the various objectives to include this variable. All instances default to 1, so nothing has been changed insofar as rewarding Operational VPs. This isn't an update to Operation VP rewards, but preparatory work for a future review.Examples of Use
The below is an example of use.
OperationalVPfor the below is actually set to 1 in this PR (as per current implementation), not 99.A Note on StratCon
With the exception of the base attacks scenario (the one you get when the enemy is Invincible), StratCon doesn't appear to use AtB's scenarios and already has this functionality. The focus of this PR is to bring that functionality to AtB scenarios, as this allows a holistic review of Operational VPs, rather than restricting any review to StratCon only.