Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize deadborder directory for MM consistency #3948

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

AaronGullickson
Copy link
Member

In MekHQ, we have a directory that is data/boards/unofficial/deadborder and in MegaMek we have a directory that is data/boards/unofficial/Deadborder. Since we use MegaMek's board folder for releases, this leads to a discrepancy when running MekHQ from source and from a release. This just capitalizes it in MekHQ to bring it in line with MegaMek. I checked other folders in that directory and they all matched.

@AaronGullickson AaronGullickson requested a review from HammerGS April 1, 2024 17:21
@AaronGullickson AaronGullickson self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.65%. Comparing base (0a2b4e4) to head (637f29d).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3948      +/-   ##
============================================
+ Coverage     10.60%   10.65%   +0.04%     
- Complexity     5487     5528      +41     
============================================
  Files           836      836              
  Lines        114266   114275       +9     
  Branches      17182    17185       +3     
============================================
+ Hits          12121    12176      +55     
+ Misses       100935   100871      -64     
- Partials       1210     1228      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thom293
Copy link
Contributor

Thom293 commented Apr 1, 2024

Nice. (edited to remove unrelated issue).

@AaronGullickson
Copy link
Member Author

No, its only going to affect maps in the unofficial/deadborder directory. I compared that map between MM and MHQ and the path appears to be identical, so I think #3776 is a different issue.

@Thom293
Copy link
Contributor

Thom293 commented Apr 1, 2024

Ok. thank you. Will edit out the number so it doesnt grab it by mistake.

@HammerGS HammerGS merged commit 3e880db into MegaMek:master Apr 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants