Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3730] Victory Point Terminology Changes #3891

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Adjusts the various uses of 'Victory Point' for added clarity.

  • 'Scenario Victory Point' renamed to 'Operational Victory Point'
  • StratCon 'Victory Point' renamed to 'Campaign Victory Point'

Any non-print references, such as variable names, have been left intact to ensure minimal risk of bugs.

Readme's have been updated to match the new terminology.

Minor grammatical changes have also been made, where relevant.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 10.64%. Comparing base (fbbf4d8) to head (cb6fd5f).

Files Patch % Lines
...q/campaign/mission/ScenarioObjectiveProcessor.java 0.00% 3 Missing ⚠️
MekHQ/src/mekhq/gui/StratconTab.java 0.00% 3 Missing ⚠️
...c/mekhq/gui/stratcon/CampaignManagementDialog.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3891   +/-   ##
=========================================
  Coverage     10.64%   10.64%           
  Complexity     5487     5487           
=========================================
  Files           834      834           
  Lines        113856   113856           
  Branches      17193    17193           
=========================================
  Hits          12119    12119           
  Misses       100528   100528           
  Partials       1209     1209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working.

@HammerGS HammerGS merged commit ba119a5 into MegaMek:master Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants