Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clearGameData #3877

Merged
merged 1 commit into from
Mar 23, 2024
Merged

update clearGameData #3877

merged 1 commit into from
Mar 23, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Mar 10, 2024 •
edited
Loading

  • reset shutdown
  • reset search lights
  • if entity has bap, default to bap

fixes MegaMek/megamek#4324

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 10.62%. Comparing base (3ea1787) to head (4b34573).

Files Patch % Lines
MekHQ/src/mekhq/campaign/Campaign.java 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3877   +/-   ##
=========================================
  Coverage     10.62%   10.62%           
  Complexity     5472     5472           
=========================================
  Files           834      834           
  Lines        113887   113891    +4     
  Branches      17201    17202    +1     
=========================================
+ Hits          12097    12099    +2     
- Misses       100582   100583    +1     
- Partials       1208     1209    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sleet01
Sleet01 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HammerGS HammerGS merged commit 80dfbd6 into MegaMek:master Mar 23, 2024
6 checks passed
HammerGS added a commit that referenced this pull request Mar 23, 2024
@HammerGS
Merging the following PR's
d1d1d9a 
+ PR #3867: Adjusted Retirement TN and Payout Values
+ Fix #3877: MekHQ units aren't defaulting to active probes for sensors
+ Fix #1812: AtB/StratCon] Base Attack (Defender) Objective Changes
+ PR #3892: Corrected Typo in Mass Repair Dialog
@kuronekochomusuke kuronekochomusuke deleted the clearGameDataUpdates branch April 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAragua NickAragua NickAragua approved these changes

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MekHQ units aren't defaulting to active probes for sensors
4 participants
@kuronekochomusuke @Sleet01 @NickAragua @HammerGS