Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chassis lookup #3843

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Feb 13, 2024

Fixes the MechSummaryCache lookup for meks with clan chassis names during scenario resolution. The MSC still uses the full names internally, e.g. Mad Cat (Timber Wolf) = entity.getFullChassis()

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7ca1733) 10.62% compared to head (831f5b0) 10.62%.

Files Patch % Lines
...kHQ/src/mekhq/campaign/ResolveScenarioTracker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3843   +/-   ##
=========================================
  Coverage     10.62%   10.62%           
  Complexity     5472     5472           
=========================================
  Files           834      834           
  Lines        113884   113884           
  Branches      17203    17203           
=========================================
  Hits          12097    12097           
  Misses       100579   100579           
  Partials       1208     1208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit bac7954 into MegaMek:master Feb 13, 2024
5 of 6 checks passed
HammerGS added a commit that referenced this pull request Feb 13, 2024
HammerGS added a commit that referenced this pull request Feb 13, 2024
+ Fix #3842: Can't load prefab campaigns
@SJuliez SJuliez deleted the scenario-resolution-clan-name-bug branch October 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants