Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3194 Awarding non-stackable medals to multiple people #3822

Merged

Conversation

jackreichelt
Copy link
Contributor

This fixes #3194. Allows selecting multiple personnel and awarding a non-stackable award, which will only be added to those who do not already have it. When a single person is selected, the awards list will still be filtered as normal.

@jackreichelt
Copy link
Contributor Author

Potentially this should still hide a non-stackable award from the list if everyone already has it. Can definitely implement that, but I'd love some feedback on if that's better UX. I am uncertain.

@JonhyBurner
Copy link

Since single personnel awards menu hides the non-stackable that person already has, hiding it when choosing multiple personnel when everyone has it would be the expected behaviour for a user. In practice, it makes no difference, though.

@jackreichelt
Copy link
Contributor Author

jackreichelt commented Jan 29, 2024

After sleeping on it, I think that not hiding the award if all of a selected group already have it is better. My rationale is that if you do hide it, people have to scroll, not see it, then double-check they haven't missed it. The list is quite long, so I think it's easy to miss things.

If you don't hide it, then when you apply it to a group, it's a simple process, with a guarantee at the end that all the selected personnel have the award (even if they had it all already).

A potential future change might be to merely disable an award in the menu, but still show it. This just helps preserve the list contents regardless of state/selection, which might make it more intuitive. But I think that's a very minor improvement, that might not be worth it.

Copy link
Collaborator

@rjhancock rjhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sane.

@HammerGS HammerGS merged commit 3aa366f into MegaMek:master Feb 4, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Awarding non-stackable medals to multiple people should award to those that do not already have the medal
5 participants