Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] Attempt to temporarily fix nightly gradle heap JVM out of mem thrashing. #3785

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

HoneySkull
Copy link
Collaborator

I would like to try this as an experiment to see what impact it has on the nightly. I suspect it could be a temporary fix for the Gradle JVM heap out of memory and thrashing errors that preventing nightly builds from succeeding while continuing investigation to a correct fix.

By default Gradle will use a max number of workers equal to the number of logical processors available. Multiple workers could be competing for available heap space and starving each other out. This should prevent that but at the cost of longer build times.

If build times are too long, it might be required to specify a larger heap space for Gradle to use while increasing the max number of workers to something that makes sense.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce24d1a) 10.63% compared to head (08e6f48) 10.63%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3785   +/-   ##
=========================================
  Coverage     10.63%   10.63%           
  Complexity     5473     5473           
=========================================
  Files           834      834           
  Lines        113772   113772           
  Branches      17196    17196           
=========================================
  Hits          12100    12100           
  Misses       100466   100466           
  Partials       1206     1206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 412b7f2 into MegaMek:master Nov 15, 2023
6 checks passed
@HammerGS
Copy link
Member

Merging to test.

@HammerGS HammerGS added Performance Build Issue PR's related to project building i.e Gradle labels Nov 15, 2023
@NickAragua
Copy link
Member

I'll let you guys close this one out as you see fit as I don't monitor builds that often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issue PR's related to project building i.e Gradle Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants