2696: Added coloring to the Unit List on the Personnell assignment menus #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
suggested changes
Apr 27, 2022
There was a problem hiding this comment.
Please swap this from tab spacing to 4 space spacing, and remove the SerialVersionUid fields as they are completely useless (only MegaMek save games use java.io.Serialization, and that is planned for removal in the near future).
There's also a few spacing change comments, but otherwise this looks good.
|
Definitely fixed the spacing issues and the extra lines. I think I fixed the tab-space issues. Not too sure though with git commit transformations. |
Windchild292
suggested changes
Apr 27, 2022
Windchild292
suggested changes
Apr 27, 2022
Windchild292
approved these changes
Apr 27, 2022
|
Sorry about that. did a search just in case. FYI there's one more in CompanyGenerationOptions |
|
I know, I've just been waiting for the final MM removal to remove any missed remnants from changes that predate the start of the removal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2696 I was looking for a good place to put the coloring, but didn't see a common place any better than in Unit.