Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Client Unknown Phase Logging During Initial Connection #2930

Merged

Conversation

Windchild292
Copy link
Contributor

This has been the cause of multiple misunderstandings, including by myself... so this should better state the situation when it comes to debugging.

…r initialization rather than an in-game issue
@Windchild292 Windchild292 added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Oct 29, 2021
@Windchild292 Windchild292 self-assigned this Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #2930 (e0cf70c) into master (fdbc6e1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2930      +/-   ##
============================================
- Coverage     10.55%   10.54%   -0.02%     
+ Complexity     3876     3867       -9     
============================================
  Files           733      733              
  Lines        101210   101210              
  Branches      16536    16536              
============================================
- Hits          10685    10674      -11     
- Misses        89150    89152       +2     
- Partials       1375     1384       +9     
Impacted Files Coverage Δ
MekHQ/src/mekhq/AtBGameThread.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/GameThread.java 0.00% <0.00%> (ø)
...ekhq/campaign/universe/RandomFactionGenerator.java 56.17% <0.00%> (-2.00%) ⬇️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.60% <0.00%> (-1.00%) ⬇️
.../mekhq/campaign/mission/enums/AtBContractType.java 12.54% <0.00%> (-0.70%) ⬇️
MekHQ/src/mekhq/campaign/universe/Faction.java 66.02% <0.00%> (-0.65%) ⬇️
MekHQ/src/mekhq/campaign/universe/Systems.java 42.23% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbc6e1...e0cf70c. Read the comment docs.

@Windchild292 Windchild292 merged commit 67ac13c into MegaMek:master Oct 30, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_UnknownPhase branch October 30, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants