Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectAbilitiesDialog: Adding SPA Display Name Sorting #2924

Conversation

Windchild292
Copy link
Contributor

It was annoying to try to find the correct SPA when bugtesting #2923, so this adds sorting to it and fixes the tab spacing.

@Windchild292 Windchild292 added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI labels Oct 27, 2021
@Windchild292 Windchild292 self-assigned this Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2924 (4562992) into master (7947574) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2924      +/-   ##
============================================
- Coverage     10.54%   10.54%   -0.01%     
+ Complexity     3867     3866       -1     
============================================
  Files           733      733              
  Lines        101239   101240       +1     
  Branches      16537    16537              
============================================
- Hits          10674    10673       -1     
- Misses        89181    89182       +1     
- Partials       1384     1385       +1     
Impacted Files Coverage Δ
...HQ/src/mekhq/gui/dialog/SelectAbilitiesDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/universe/Faction.java 65.38% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7947574...4562992. Read the comment docs.

@Windchild292 Windchild292 merged commit c612720 into MegaMek:master Oct 28, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_SpecialAbilitiesDialogSorting branch October 28, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants