Briefing Room: Print Sheets now prints sheets for all units in AtB #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
added
(RFE) Enhancement
Windchild292
commented
Sep 25, 2021
Comment on lines
+556
to
+562
| if (scenario instanceof AtBScenario) { | ||
| // Also print off allied sheets and all bot force sheets | ||
| chosen.addAll(((AtBScenario) scenario).getAlliesPlayer()); | ||
| chosen.addAll(((AtBScenario) scenario).getBotForces().stream() | ||
| .flatMap(botForce -> botForce.getEntityList().stream()) | ||
| .collect(Collectors.toList())); | ||
| } |
There was a problem hiding this comment.
This is the new functionality, where we also print off Player controlled allies and any bot force units
Codecov Report
@@ Coverage Diff @@
## master #2884 +/- ##
============================================
+ Coverage 10.62% 10.64% +0.01%
- Complexity 3876 3891 +15
============================================
Files 721 721
Lines 100582 100582
Branches 16425 16424 -1
============================================
+ Hits 10683 10703 +20
+ Misses 88508 88501 -7
+ Partials 1391 1378 -13
Continue to review full report at Codecov.
|
NickAragua
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been raised on Discord a few times recently, so I've added it. I also cleaned up the code for the method and fixed any IDE warnings (protected makes no sense in a final class and unnecessary toString usages being the primary two).
To review: I put a comment over the actual functionality change, which was supposed to be in its own commit.