Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2858: StratCon Tab NPE #2861

Merged

Conversation

Windchild292
Copy link
Contributor

This fixes a NPE that occurs when showing the StratCon state management, found in the logs for #2858

@Windchild292 Windchild292 self-assigned this Sep 3, 2021
@Windchild292 Windchild292 added the StratCon Bugs relating strictly to StratCon label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #2861 (0deb651) into master (5a23a6c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2861      +/-   ##
============================================
- Coverage     10.64%   10.62%   -0.02%     
+ Complexity     3886     3875      -11     
============================================
  Files           721      721              
  Lines        100550   100552       +2     
  Branches      16415    16416       +1     
============================================
- Hits          10700    10685      -15     
- Misses        88470    88476       +6     
- Partials       1380     1391      +11     
Impacted Files Coverage Δ
MekHQ/src/mekhq/gui/StratconTab.java 0.00% <0.00%> (ø)
...ekhq/campaign/universe/RandomFactionGenerator.java 56.17% <0.00%> (-2.00%) ⬇️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.60% <0.00%> (-1.00%) ⬇️
MekHQ/src/mekhq/campaign/universe/Systems.java 41.43% <0.00%> (-0.80%) ⬇️
.../mekhq/campaign/mission/enums/AtBContractType.java 12.54% <0.00%> (-0.70%) ⬇️
MekHQ/src/mekhq/campaign/universe/Faction.java 65.38% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a23a6c...0deb651. Read the comment docs.

@Windchild292 Windchild292 merged commit 8ad4928 into MegaMek:master Sep 3, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_StratConTabNPE branch September 3, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants