Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent out of bounds array access #2849

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

NickAragua
Copy link
Member

For aerospace/space scenarios the terrain type is out of bounds of the array above the changed code. We don't actually want to change the terrain type, but we want to avoid array out of bounds exceptions. This would manifest in aerospace scenarios failing to appear on the stratcon map.

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #2849 (db0c43b) into master (616cfdb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2849      +/-   ##
============================================
- Coverage     10.64%   10.63%   -0.01%     
+ Complexity     3886     3879       -7     
============================================
  Files           721      721              
  Lines        100547   100550       +3     
  Branches      16413    16414       +1     
============================================
- Hits          10699    10691       -8     
- Misses        88469    88476       +7     
- Partials       1379     1383       +4     
Impacted Files Coverage Δ
MekHQ/src/mekhq/campaign/mission/AtBScenario.java 0.00% <0.00%> (ø)
...ekhq/campaign/universe/RandomFactionGenerator.java 56.17% <0.00%> (-2.40%) ⬇️
MekHQ/src/mekhq/campaign/universe/Faction.java 64.74% <0.00%> (-1.93%) ⬇️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 59.80% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616cfdb...db0c43b. Read the comment docs.

@NickAragua NickAragua merged commit 1921ebf into MegaMek:master Aug 30, 2021
@NickAragua NickAragua deleted the fix_aerospace_scenario_gen branch July 2, 2023 02:48
@HammerGS HammerGS added the StratCon Bugs relating strictly to StratCon label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants