Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportHyperlinkListener: Rework, Code Scanning Alert Fixes #2818

Conversation

Windchild292
Copy link
Contributor

This PR fixes tab spacing, if formatting, and properly catches multiple parsing exceptions. This has come up when working on both #2811 and #2817

@Windchild292 Windchild292 added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Aug 19, 2021
@Windchild292 Windchild292 self-assigned this Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2818 (32d15a5) into master (f5280e1) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2818      +/-   ##
============================================
+ Coverage     10.61%   10.62%   +0.01%     
- Complexity     3871     3880       +9     
============================================
  Files           717      717              
  Lines        100254   100264      +10     
  Branches      16422    16422              
============================================
+ Hits          10640    10652      +12     
- Misses        88227    88234       +7     
+ Partials       1387     1378       -9     
Impacted Files Coverage Δ
MekHQ/src/mekhq/gui/ReportHyperlinkListener.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/universe/Faction.java 66.66% <0.00%> (+0.64%) ⬆️
.../mekhq/campaign/mission/enums/AtBContractType.java 13.28% <0.00%> (+0.69%) ⬆️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.95% <0.00%> (+1.00%) ⬆️
...ekhq/campaign/universe/RandomFactionGenerator.java 58.16% <0.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5280e1...32d15a5. Read the comment docs.

@Windchild292 Windchild292 merged commit fca59e9 into MegaMek:master Aug 24, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_ReportHyperlinkListener branch August 24, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants