274: Moving Era Definitions to Data #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
added
the
(RFE) Enhancement
HammerGS
reviewed
Aug 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #2805 +/- ##
=========================================
Coverage 10.61% 10.61%
- Complexity 3870 3878 +8
=========================================
Files 717 719 +2
Lines 100256 100317 +61
Branches 16423 16423
=========================================
+ Hits 10639 10649 +10
- Misses 88229 88288 +59
+ Partials 1388 1380 -8
Continue to review full report at Codecov.
|
NickAragua
approved these changes
Aug 18, 2021
|
|
||
| MekHQ.getLogger().error("Failed to determine a valid era for the date " + today); | ||
| return getEras().values().stream().findFirst().orElse(new Era()); | ||
| return getEras().ceilingEntry(today).getValue(); |
There was a problem hiding this comment.
I assume this works for dates past ilClan?
There was a problem hiding this comment.
ilClan doesn't have an end date, so it uses the default of 01-01-9999... which should handle any dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #274 by rewriting eras and moving them to file. They're barely used currently, but having a more robust and customizable system should help in the future.