Transaction Type Enum: Expanded Personnel Transaction Types #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
added
the
(RFE) Enhancement
Codecov Report
@@ Coverage Diff @@
## master #2793 +/- ##
============================================
+ Coverage 10.62% 10.65% +0.02%
- Complexity 3876 3880 +4
============================================
Files 717 718 +1
Lines 100126 100194 +68
Branches 16404 16413 +9
============================================
+ Hits 10642 10679 +37
- Misses 88101 88136 +35
+ Partials 1383 1379 -4
Continue to review full report at Codecov.
|
NickAragua
approved these changes
Aug 13, 2021
|
Merging post-0.49.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps TransactionType to an Enum, adds a few new TransactionTypes (Recruitment and Retirement being the two primary ones), and standardizes the debit/credit methods to follow the exact same order as the Transaction constructor.
Most of the changes are just automated imports.