Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finances: Loan Refactoring/Standardization #2782

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

Windchild292
Copy link
Contributor

Finances file three refactor: Loan

@Windchild292 Windchild292 added (RFE) Enhancement Requests for Enhancement, new features or implementations Refactoring labels Jul 30, 2021
@Windchild292 Windchild292 self-assigned this Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #2782 (72d54ff) into master (61ef12e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2782      +/-   ##
============================================
- Coverage     10.62%   10.62%   -0.01%     
+ Complexity     3876     3874       -2     
============================================
  Files           717      717              
  Lines        100142   100126      -16     
  Branches      16398    16404       +6     
============================================
- Hits          10643    10641       -2     
+ Misses        88119    88103      -16     
- Partials       1380     1382       +2     
Impacted Files Coverage Δ
MekHQ/src/mekhq/campaign/Campaign.java 11.88% <0.00%> (+<0.01%) ⬆️
MekHQ/src/mekhq/campaign/finances/Finances.java 3.18% <0.00%> (+0.02%) ⬆️
MekHQ/src/mekhq/campaign/finances/Loan.java 0.00% <0.00%> (ø)
...Q/src/mekhq/gui/adapter/LoanTableMouseAdapter.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/NewLoanDialog.java 0.00% <0.00%> (ø)
...ekHQ/src/mekhq/gui/dialog/PayCollateralDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/model/LoanTableModel.java 0.00% <0.00%> (ø)
.../mekhq/campaign/mission/enums/AtBContractType.java 12.58% <0.00%> (-0.70%) ⬇️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.55% <0.00%> (-0.41%) ⬇️
MekHQ/src/mekhq/campaign/universe/Systems.java 42.23% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ef12e...72d54ff. Read the comment docs.

@Windchild292 Windchild292 merged commit d90684b into MegaMek:master Aug 6, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_Loan branch August 6, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants