Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finances Tab: Price Multipliers Panel Cleanup and Expansion #2775

Conversation

Windchild292
Copy link
Contributor

This expands the customizability and cleans up the price multipliers options both code-wise and visually, plus fixes a bug where damaged parts didn't have their quality taken into account when determining the price.

@Windchild292 Windchild292 added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Jul 28, 2021
@Windchild292 Windchild292 self-assigned this Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #2775 (82b8024) into master (b0887cb) will increase coverage by 0.01%.
The diff coverage is 10.67%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2775      +/-   ##
============================================
+ Coverage     10.60%   10.61%   +0.01%     
- Complexity     3861     3875      +14     
============================================
  Files           719      719              
  Lines        100083   100229     +146     
  Branches      16400    16413      +13     
============================================
+ Hits          10609    10635      +26     
- Misses        88087    88213     +126     
+ Partials       1387     1381       -6     
Impacted Files Coverage Δ
.../src/mekhq/gui/adapter/PartsTableMouseAdapter.java 0.00% <0.00%> (ø)
...Q/src/mekhq/gui/adapter/UnitTableMouseAdapter.java 0.00% <0.00%> (ø)
...HQ/src/mekhq/gui/dialog/CampaignOptionsDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/parts/Part.java 34.94% <9.09%> (-0.14%) ⬇️
MekHQ/src/mekhq/campaign/CampaignOptions.java 26.93% <24.54%> (+0.46%) ⬆️
MekHQ/src/mekhq/campaign/unit/Unit.java 20.23% <71.42%> (-0.02%) ⬇️
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.01% <0.00%> (-0.30%) ⬇️
...ekhq/campaign/universe/RandomFactionGenerator.java 56.17% <0.00%> (ø)
.../mekhq/campaign/mission/enums/AtBContractType.java 13.28% <0.00%> (+0.69%) ⬆️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.95% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0887cb...82b8024. Read the comment docs.

@Windchild292 Windchild292 merged commit ff9f1ff into MegaMek:master Jul 30, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_ExpandedFinancesTabCostSpinners branch July 30, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants