Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass Mothball Dialog: Fixing IndexOutOfBoundsException with no techs for a unit type #2744

Conversation

Windchild292
Copy link
Contributor

This fixes a bug raised on Discord.

@Windchild292 Windchild292 self-assigned this Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #2744 (f9db934) into master (d2c6f3e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2744   +/-   ##
=========================================
  Coverage     10.60%   10.60%           
- Complexity     3851     3855    +4     
=========================================
  Files           717      717           
  Lines         99772    99774    +2     
  Branches      16402    16403    +1     
=========================================
+ Hits          10582    10586    +4     
- Misses        87810    87811    +1     
+ Partials       1380     1377    -3     
Impacted Files Coverage Δ
MekHQ/src/mekhq/gui/dialog/MassMothballDialog.java 0.00% <0.00%> (ø)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.95% <0.00%> (+0.20%) ⬆️
MekHQ/src/mekhq/campaign/universe/Faction.java 66.66% <0.00%> (+0.65%) ⬆️
.../mekhq/campaign/mission/enums/AtBContractType.java 13.28% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c6f3e...f9db934. Read the comment docs.

@Windchild292 Windchild292 merged commit ffdcde2 into MegaMek:master Jul 13, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_NoSelectedTechsMassMothball branch July 13, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants