Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2116/2589: Improving Rank and Title Sorting #2697

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

@Windchild292 Windchild292 added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI labels Jun 10, 2021
@Windchild292 Windchild292 self-assigned this Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #2697 (bf37d6f) into master (1dbf2d2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2697      +/-   ##
============================================
- Coverage     10.65%   10.63%   -0.02%     
+ Complexity     3849     3840       -9     
============================================
  Files           712      715       +3     
  Lines         99124    99203      +79     
  Branches      16304    16319      +15     
============================================
- Hits          10564    10553      -11     
- Misses        87188    87269      +81     
- Partials       1372     1381       +9     
Impacted Files Coverage Δ
MekHQ/src/mekhq/campaign/personnel/Person.java 12.22% <0.00%> (ø)
MekHQ/src/mekhq/gui/HangarTab.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/InfirmaryTab.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/PersonnelTab.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/BatchXPDialog.java 0.00% <0.00%> (ø)
...rc/mekhq/gui/dialog/RetirementDefectionDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/model/UnitTableModel.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/sorter/PersonRankSorter.java 0.00% <0.00%> (ø)
...Q/src/mekhq/gui/sorter/PersonRankStringSorter.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/sorter/PersonTitleSorter.java 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbf2d2...bf37d6f. Read the comment docs.

@Windchild292 Windchild292 merged commit a215e52 into MegaMek:master Jun 11, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_2589 branch June 11, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
2 participants