Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM Tools Dialog Rewrite #2693

Merged
merged 12 commits into from
Jun 11, 2021

Conversation

Windchild292
Copy link
Contributor

This PR is a complete rewrite of the GM Tools Dialog. It does the following:

  • Move to AbstractDialog
  • Divide into General and Names Tab
  • Modal only when editing a person
  • Expanding null protections
  • Expanding the options for rolling dice
  • RAT Unit Readout Display
  • Improve name generation display with large numbers of names

@Windchild292 Windchild292 added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI labels Jun 10, 2021
@Windchild292 Windchild292 self-assigned this Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #2693 (ba6f208) into master (1dbf2d2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2693      +/-   ##
============================================
- Coverage     10.65%   10.62%   -0.04%     
  Complexity     3849     3849              
============================================
  Files           712      717       +5     
  Lines         99124    99440     +316     
  Branches      16304    16329      +25     
============================================
  Hits          10564    10564              
- Misses        87188    87504     +316     
  Partials       1372     1372              
Impacted Files Coverage Δ
MekHQ/src/mekhq/campaign/personnel/Bloodname.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/personnel/Clan.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/universe/Faction.java 66.66% <0.00%> (-0.44%) ⬇️
MekHQ/src/mekhq/gui/CampaignGUI.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/GMToolsDialog.java 0.00% <0.00%> (ø)
...kHQ/src/mekhq/gui/displayWrappers/ClanDisplay.java 0.00% <0.00%> (ø)
.../src/mekhq/gui/displayWrappers/FactionDisplay.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/HangarTab.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/InfirmaryTab.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/personnel/Person.java 12.22% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbf2d2...ba6f208. Read the comment docs.

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor nitpicks, looks fine otherwise.

@Windchild292 Windchild292 merged commit cb1d95f into MegaMek:master Jun 11, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_GMToolsDialog branch June 11, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants