Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing NONE Primary Role Hiring #2667

Merged
merged 2 commits into from
May 31, 2021

Conversation

Windchild292
Copy link
Contributor

The NONE Role is supposed to be a secondary role only. This prevents you from hiring a person with NONE as a primary role.

The second commit refactors the personnel role methods into streams

@Windchild292 Windchild292 added Bug Personnel Personnel-related Issues labels May 31, 2021
@Windchild292 Windchild292 self-assigned this May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #2667 (b329457) into master (c4db818) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2667      +/-   ##
============================================
- Coverage     10.72%   10.72%   -0.01%     
+ Complexity     3826     3821       -5     
============================================
  Files           704      704              
  Lines         98446    98428      -18     
  Branches      16355    16345      -10     
============================================
- Hits          10561    10553       -8     
+ Misses        86508    86493      -15     
- Partials       1377     1382       +5     
Impacted Files Coverage Δ
.../mekhq/campaign/personnel/enums/PersonnelRole.java 35.33% <0.00%> (+4.41%) ⬆️
MekHQ/src/mekhq/gui/CampaignGUI.java 0.00% <0.00%> (ø)
.../src/mekhq/gui/dialog/HireBulkPersonnelDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/universe/Systems.java 41.43% <0.00%> (-0.80%) ⬇️
...Q/src/mekhq/campaign/universe/RegionPerimeter.java 83.33% <0.00%> (-0.70%) ⬇️
...ekhq/campaign/universe/RandomFactionGenerator.java 58.40% <0.00%> (-0.40%) ⬇️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.62% <0.00%> (-0.40%) ⬇️
MekHQ/src/mekhq/campaign/universe/Planet.java 26.07% <0.00%> (-0.23%) ⬇️
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.07% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4db818...b329457. Read the comment docs.

@Windchild292 Windchild292 merged commit 0280a93 into MegaMek:master May 31, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_NonePrimary branch May 31, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants