Cleaning up a few erroneous Campaign GUI properties #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
added
(RFE) Enhancement
Codecov Report
@@ Coverage Diff @@
## master #2656 +/- ##
============================================
- Coverage 10.78% 10.77% -0.01%
+ Complexity 3824 3823 -1
============================================
Files 703 703
Lines 97926 97926
Branches 16272 16272
============================================
- Hits 10557 10556 -1
Misses 85991 85991
- Partials 1378 1379 +1
Continue to review full report at Codecov.
|
NickAragua
approved these changes
May 31, 2021
| @@ -75,23 +75,19 @@ miCargoReport.text=Cargo Report... | |||
| # View Menu | |||
| menuView.text=View | |||
| miShowHistoricalReportLog.text=Historical Daily Report Log | |||
| miDetachLog.text=Detach Daily Report Log | |||
| miAttachLog.text=Attach Daily Report Log | |||
There was a problem hiding this comment.
We really ought to look at making the daily log detachable again. It's such a pain in the ass to have to keep going back to the command center tab for it.
There was a problem hiding this comment.
I concur, and will open up an issue to open it in its own modeless window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed lines were unused, and the dialog tags were the only ones to load dialogs without the ...