Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small unit contract init fix #2646

Merged
merged 3 commits into from
May 29, 2021
Merged

Small unit contract init fix #2646

merged 3 commits into from
May 29, 2021

Conversation

NickAragua
Copy link
Member

@NickAragua NickAragua commented May 26, 2021 •
edited
Loading

Three changes:

  • compilation fix
  • convoy escort objective properly lists force
  • ensure minimum objective count for small unit sizes (objective count rounds to 0 sometimes).

Addresses #2633

sixlettervariables
sixlettervariables suggested changes May 26, 2021
View reviewed changes
Copy link
Contributor

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing unit test.

@MegaMek MegaMek deleted a comment from codecov bot May 27, 2021
@NickAragua NickAragua merged commit 4c2b9e7 into MegaMek:master May 29, 2021
@NickAragua NickAragua deleted the small_unit_contract_init_fix branch May 29, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixlettervariables sixlettervariables sixlettervariables approved these changes

@neoancient neoancient Awaiting requested review from neoancient

@Windchild292 Windchild292 Awaiting requested review from Windchild292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickAragua @sixlettervariables