Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple grounded dropship issues #2599

Merged
merged 3 commits into from
May 10, 2021

Conversation

NickAragua
Copy link
Member

@NickAragua NickAragua commented May 10, 2021

Four changes:

  • grounded dropships were unavailable as potential scenario modifiers even though they should have been
  • customize scenario dialog would reset status to null if editing a non-resolved scenario
  • invoke full "land" code to set all appropriate values when initializing a grounded aerospace unit
  • don't deploy opfor directly underneath allied dropship in 'Defend Dropship' scenario

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #2599 (44af08f) into master (7bfeedc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 44af08f differs from pull request most recent head 8010520. Consider uploading reports for the commit 8010520 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2599   +/-   ##
=========================================
  Coverage     10.73%   10.74%           
- Complexity     3804     3807    +3     
=========================================
  Files           700      700           
  Lines         97888    97891    +3     
  Branches      16305    16307    +2     
=========================================
+ Hits          10510    10516    +6     
  Misses        85999    85999           
+ Partials       1379     1376    -3     
Impacted Files Coverage Δ Complexity Δ
...hq/campaign/mission/AtBDynamicScenarioFactory.java 1.73% <0.00%> (-0.01%) 12.00 <0.00> (ø)
.../src/mekhq/gui/dialog/CustomizeScenarioDialog.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ekhq/campaign/universe/RandomFactionGenerator.java 58.80% <0.00%> (ø) 66.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.19% <0.00%> (+0.11%) 67.00% <0.00%> (+1.00%)
MekHQ/src/mekhq/campaign/universe/Planet.java 26.30% <0.00%> (+0.22%) 25.00% <0.00%> (ø%)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.77% <0.00%> (+0.39%) 113.00% <0.00%> (+1.00%)
MekHQ/src/mekhq/campaign/universe/Systems.java 42.23% <0.00%> (+0.79%) 36.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfeedc...8010520. Read the comment docs.

@NickAragua NickAragua merged commit 2babc14 into MegaMek:master May 10, 2021
@NickAragua NickAragua deleted the fix_grounded_dropships branch May 10, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants