Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing LAM Pilot Skill Level Calculation #2586

Merged

Conversation

Windchild292
Copy link
Contributor

This fixes a bug reported on Discord

@Windchild292 Windchild292 added Bug Personnel Personnel-related Issues labels May 5, 2021
@Windchild292 Windchild292 self-assigned this May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #2586 (e847e4d) into master (2b38d94) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2586      +/-   ##
============================================
- Coverage     10.74%   10.73%   -0.01%     
+ Complexity     3806     3804       -2     
============================================
  Files           700      700              
  Lines         97872    97872              
  Branches      16304    16304              
============================================
- Hits          10514    10511       -3     
- Misses        85980    85982       +2     
- Partials       1378     1379       +1     
Impacted Files Coverage Δ Complexity Δ
MekHQ/src/mekhq/campaign/personnel/Person.java 11.35% <0.00%> (ø) 63.00 <0.00> (ø)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.38% <0.00%> (-0.40%) 112.00% <0.00%> (-1.00%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.07% <0.00%> (-0.12%) 66.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b38d94...e847e4d. Read the comment docs.

@Windchild292 Windchild292 merged commit ccf55cc into MegaMek:master May 9, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_LAMPilotSkillLevel branch May 9, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants