Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign Options: Fixing doClick issue #2580

Merged
merged 1 commit into from
May 5, 2021

Conversation

Windchild292
Copy link
Contributor

This fixes a bug whereby if you had a different value for a value that you normally want to use its actionlistener for to disable other values, it wouldn't update properly when disabled.

@Windchild292 Windchild292 self-assigned this May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2580 (14e823a) into master (c5b057c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2580      +/-   ##
============================================
- Coverage     10.74%   10.74%   -0.01%     
- Complexity     3804     3806       +2     
============================================
  Files           700      700              
  Lines         97835    97839       +4     
  Branches      16300    16302       +2     
============================================
- Hits          10511    10510       -1     
- Misses        85946    85951       +5     
  Partials       1378     1378              
Impacted Files Coverage Δ Complexity Δ
...HQ/src/mekhq/gui/dialog/CampaignOptionsDialog.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.77% <0.00%> (-0.60%) 113.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/universe/Planet.java 26.07% <0.00%> (-0.23%) 25.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.19% <0.00%> (+0.11%) 67.00% <0.00%> (+1.00%)
MekHQ/src/mekhq/campaign/universe/Systems.java 42.23% <0.00%> (+0.79%) 36.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b057c...14e823a. Read the comment docs.

@Windchild292 Windchild292 merged commit 936749d into MegaMek:master May 5, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_doClick branch May 5, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants