Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2469: Fixing Award Log Edit NPEs #2471

Merged
merged 5 commits into from
Mar 17, 2021

Conversation

Windchild292
Copy link
Contributor

@Windchild292 Windchild292 commented Mar 14, 2021

This fixes #2469. As part of that fix, I've also moved the dialog to extend AbstractMHQButtonDialog.

@Windchild292 Windchild292 added Bug (RFE) Enhancement Requests for Enhancement, new features or implementations labels Mar 14, 2021
@Windchild292 Windchild292 self-assigned this Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #2471 (23df0b8) into master (7156e17) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2471      +/-   ##
============================================
+ Coverage     10.40%   10.43%   +0.02%     
- Complexity     3439     3444       +5     
============================================
  Files           669      669              
  Lines         94279    94280       +1     
  Branches      15825    15828       +3     
============================================
+ Hits           9810     9835      +25     
+ Misses        83101    83078      -23     
+ Partials       1368     1367       -1     
Impacted Files Coverage Δ Complexity Δ
MekHQ/src/mekhq/campaign/log/AwardLogEntry.java 33.33% <0.00%> (-6.67%) 1.00 <0.00> (ø)
MekHQ/src/mekhq/campaign/log/AwardLogger.java 33.33% <0.00%> (-3.51%) 3.00 <0.00> (ø)
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...src/mekhq/gui/control/EditPersonnelLogControl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ekhq/gui/dialog/AddOrEditPersonnelEntryDialog.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../mekhq/campaign/universe/FactionBorderTracker.java 68.87% <0.00%> (-2.05%) 35.00% <0.00%> (-1.00%)
...Q/src/mekhq/campaign/universe/RegionPerimeter.java 83.33% <0.00%> (-0.70%) 39.00% <0.00%> (-1.00%)
MekHQ/src/mekhq/campaign/unit/Unit.java 20.28% <0.00%> (-0.04%) 208.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.20% <0.00%> (+0.11%) 65.00% <0.00%> (+1.00%)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 59.09% <0.00%> (+0.79%) 114.00% <0.00%> (+2.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7156e17...23df0b8. Read the comment docs.

@Windchild292 Windchild292 marked this pull request as ready for review March 16, 2021 15:02
@Windchild292 Windchild292 merged commit 4b0da7e into MegaMek:master Mar 17, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_2469 branch March 17, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE on Edit Personnel Log entry
2 participants