Base Components #2440
Merged
Base Components #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for itself. However, it is a good location to manage preferences between separate dialogs
Windchild292
added
(RFE) Enhancement
Codecov Report
@@ Coverage Diff @@
## master #2440 +/- ##
============================================
+ Coverage 10.36% 10.41% +0.05%
- Complexity 3432 3441 +9
============================================
Files 675 669 -6
Lines 94574 94203 -371
Branches 15870 15816 -54
============================================
+ Hits 9799 9812 +13
+ Misses 83401 83025 -376
+ Partials 1374 1366 -8
Continue to review full report at Codecov.
|
Windchild292
requested review from
sixlettervariables,
neoancient and
NickAragua
NickAragua
approved these changes
Mar 13, 2021
| * - "Cancel.text" -> text for the cancel button | ||
| * - "Cancel.toolTipText" -> toolTipText for the cancel button | ||
| */ | ||
| public abstract class AbstractMHQButtonDialog extends AbstractButtonDialog { |
There was a problem hiding this comment.
Gotta ask, what's different about a MekHQ button from a MegaMek button?
There was a problem hiding this comment.
Solely tracking on MHQ's preferencez instead of MM's.
Otherwise the dialogs are identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is divided into two groupings, new Preferences and Abstract Components. The new Abstract Components are designed to be used as a basis for MekHQ GUI components. All base components for these are accessible component, with the abstraction being only light modifications from those bases. The primary functionality of these components is implementing preferences, handling resources, and handling the frame. Some implement initialization, while others have it as an abstract method that needs to be implemented by child classes. This information is provided in a JavaDoc comment at the top of each file.
Base Components: AbstractDialog, AbstractButtonDialog, AbstractScrollPane, AbstractSplitPane, and AbstractTabbedPane
New Preferences: JSplitPanePreference, JTabbedPanePreference, JListPreference, and JDoubleNumberSpinnerPreference
To Review: The first four commits are refactoring, organizing, and standardizing preferences, 5-7 are the primary logic changes, 8-10 are bugfixes and remove ScrollPanes, and 11 re-adds the removed AbstractScrollPane (I couldn't get the preferences working, but forgot about the other use of having it standardized as abstract, namely in being able to reuse the preferences between places it is used), while 12 is the change that moves the base components and preferences to MegaMek.
All have been tested, but are left largely unimplemented as part of this PR to minimize the footprint.