Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2429: Fixing minimum Excel version #2436

Closed
wants to merge 1 commit into from
Closed

Conversation

Windchild292
Copy link
Contributor

This fixes one of the two issues raised in #2429, namely an issue with the award documentation about the minimum version. It should be 2019, not 2016.

@Windchild292 Windchild292 added this to the 0.48-stable milestone Feb 21, 2021
@Windchild292 Windchild292 self-assigned this Feb 21, 2021
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #2436 (e6de269) into master (0142a5d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2436   +/-   ##
=========================================
  Coverage     10.32%   10.33%           
- Complexity     3412     3415    +3     
=========================================
  Files           673      673           
  Lines         94691    94691           
  Branches      15926    15926           
=========================================
+ Hits           9780     9784    +4     
+ Misses        83542    83539    -3     
+ Partials       1369     1368    -1     
Impacted Files Coverage Δ Complexity Δ
MekHQ/src/mekhq/campaign/universe/Planet.java 26.07% <0.00%> (-0.23%) 25.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.22% <0.00%> (+0.11%) 65.00% <0.00%> (+1.00%)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.46% <0.00%> (+0.39%) 113.00% <0.00%> (+1.00%)
MekHQ/src/mekhq/campaign/universe/Systems.java 42.23% <0.00%> (+0.79%) 36.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0142a5d...95c1d78. Read the comment docs.

@Windchild292
Copy link
Contributor Author

Closing as this has been made unnecessary by @BullseyeSmith's awards documentation changes.

@Windchild292 Windchild292 deleted the dev_Windchild_2429 branch February 26, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant