Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Tab: Adding better information blockers for Null/Void Signature System and Chameleon Shield #2381

Merged

Conversation

Windchild292
Copy link
Contributor

This adds more informative blockers for the Null Signature System, Void Signature System, and Chameleon Shield. I'm not sold on how this is done, but it does work properly.

@Windchild292 Windchild292 self-assigned this Jan 19, 2021
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #2381 (1b44d5e) into master (6c88fdf) will decrease coverage by 0.01%.
The diff coverage is 7.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2381      +/-   ##
============================================
- Coverage     10.32%   10.31%   -0.02%     
+ Complexity     3408     3402       -6     
============================================
  Files           673      673              
  Lines         94641    94709      +68     
  Branches      15914    15936      +22     
============================================
- Hits           9774     9766       -8     
- Misses        83490    83566      +76     
  Partials       1377     1377              
Impacted Files Coverage Δ Complexity Δ
MekHQ/src/mekhq/campaign/parts/MekLocation.java 30.71% <0.00%> (-0.68%) 72.00 <0.00> (ø)
.../mekhq/campaign/parts/equipment/EquipmentPart.java 78.18% <ø> (-0.80%) 150.00 <0.00> (-3.00)
...Q/src/mekhq/campaign/parts/MissingMekLocation.java 23.39% <14.28%> (-1.30%) 21.00 <0.00> (ø)
...ekhq/campaign/universe/RandomFactionGenerator.java 56.01% <0.00%> (-2.08%) 58.00% <0.00%> (-3.00%)
...mekhq/campaign/parts/equipment/MissingAmmoBin.java 68.08% <0.00%> (-0.67%) 18.00% <0.00%> (-1.00%)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 57.48% <0.00%> (-0.40%) 109.00% <0.00%> (-1.00%)
MekHQ/src/mekhq/campaign/Campaign.java 11.18% <0.00%> (-0.09%) 93.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/unit/Unit.java 20.33% <0.00%> (-0.06%) 207.00% <0.00%> (ø%)
MekHQ/src/mekhq/Utilities.java 7.66% <0.00%> (ø) 19.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c88fdf...1b44d5e. Read the comment docs.

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text adjustment. Also, I don't really see a point to changing EquipmentPart.java if all you're doing is whitespace changes.

MekHQ/src/mekhq/campaign/parts/MissingMekLocation.java Outdated Show resolved Hide resolved
@Windchild292
Copy link
Contributor Author

The EquipmentPart changes are an automatic IDE cleanup after I reverted some changes, as I originally thought the issue was there

@Windchild292 Windchild292 added this to the 0.48-stable milestone Jan 27, 2021
@Windchild292 Windchild292 merged commit 0273fe4 into MegaMek:master Feb 24, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_MultiCritRepairBlocks branch February 24, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants