Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infantry Motive Type File I/O Fixes #2372

Merged

Conversation

Windchild292
Copy link
Contributor

This PR fixes the save format for the mode, namely that it should be saving as an enum. This also removes eight year old migration code that ends up causing issues during parsing. I found this issue while working on some modernization and simplifications relating to the EntityMovementMode enum, but thought this issue should be fixed for stable.

@Windchild292 Windchild292 added this to the 0.48-stable milestone Jan 14, 2021
@Windchild292 Windchild292 self-assigned this Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2372 (3589bb4) into master (b0e44da) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2372      +/-   ##
============================================
- Coverage     10.33%   10.33%   -0.01%     
+ Complexity     3410     3409       -1     
============================================
  Files           673      673              
  Lines         94643    94640       -3     
  Branches      15915    15914       -1     
============================================
- Hits           9779     9777       -2     
+ Misses        83489    83487       -2     
- Partials       1375     1376       +1     
Impacted Files Coverage Δ Complexity Δ
...Q/src/mekhq/campaign/parts/InfantryMotiveType.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ekhq/campaign/parts/MissingInfantryMotiveType.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/campaign/universe/Systems.java 41.43% <0.00%> (-0.80%) 35.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9eab51...3589bb4. Read the comment docs.

@Windchild292 Windchild292 merged commit b47adac into MegaMek:master Jan 14, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_InfantryMotiveType branch January 14, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants