Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip ComStar as an origin faction #2354

Conversation

sixlettervariables
Copy link
Contributor

I misunderstood the usage of the INACTIVE tag when I wrote the random origin code, and this fixes it such that ComStar can be selected as a random origin. This also adds the SPECIAL tag to the reject list, otherwise "All Clans" shows up.

I believe this passes the bar of being simple enough for Stable.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #2354 (8b90434) into master (3c8a806) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2354      +/-   ##
============================================
- Coverage     10.32%   10.32%   -0.01%     
+ Complexity     3413     3411       -2     
============================================
  Files           673      673              
  Lines         94639    94641       +2     
  Branches      15908    15909       +1     
============================================
- Hits           9776     9772       -4     
- Misses        83492    83497       +5     
- Partials       1371     1372       +1     
Impacted Files Coverage Δ Complexity Δ
...mekhq/campaign/universe/RangedFactionSelector.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/campaign/universe/Systems.java 41.43% <0.00%> (-0.80%) 35.00% <0.00%> (-1.00%)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 58.07% <0.00%> (-0.40%) 112.00% <0.00%> (-1.00%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.10% <0.00%> (-0.12%) 64.00% <0.00%> (-1.00%)
...ekhq/campaign/universe/RandomFactionGenerator.java 60.58% <0.00%> (+0.41%) 65.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8a806...5b548ce. Read the comment docs.

@sixlettervariables sixlettervariables merged commit feb1886 into MegaMek:master Jan 8, 2021
@sixlettervariables sixlettervariables deleted the issue-comstar-origin-missing branch January 8, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants