Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Log Display Spacing #2302

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

Windchild292
Copy link
Contributor

This fixes a minor display issue whereby the dates are sometimes cut off.

Copy link
Contributor

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you get rid of the arbitrary constant by adding two characters to the string?

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #2302 (0ac59fc) into master (e9ff114) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2302      +/-   ##
===========================================
- Coverage      8.35%   8.35%   -0.01%     
  Complexity     2602    2602              
===========================================
  Files           672     672              
  Lines         95008   95009       +1     
  Branches      15965   15966       +1     
===========================================
  Hits           7936    7936              
  Misses        86007   86007              
- Partials       1065    1066       +1     
Impacted Files Coverage Δ Complexity Δ
...HQ/src/mekhq/gui/model/PersonnelEventLogModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...kHQ/src/mekhq/gui/model/PersonnelKillLogModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...hq/campaign/parts/equipment/LargeCraftAmmoBin.java 55.06% <33.33%> (-0.71%) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ff114...828c6d2. Read the comment docs.

@Windchild292
Copy link
Contributor Author

We can, and done.

@Windchild292 Windchild292 merged commit 8446670 into MegaMek:master Dec 21, 2020
@Windchild292 Windchild292 deleted the dev_Windchild_LogDateSpace branch December 21, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants