Remove old migration code #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlettervariables
requested review from
neoancient,
NickAragua and
Windchild292
Windchild292
approved these changes
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #2289 +/- ##
========================================
Coverage 8.34% 8.35%
Complexity 2601 2601
========================================
Files 672 672
Lines 95094 95008 -86
Branches 16003 15965 -38
========================================
- Hits 7935 7934 -1
+ Misses 86092 86008 -84
+ Partials 1067 1066 -1
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 4f6987d into b7bcc99 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all migration code older than the 0.4X series. Right now the remaining migrations are pretty generous and captures all of the relevant migrations in that series. Migrations from 0.2.X or 0.3.X would require using 0.46.1, then moving to 0.48+.
This is also pretty conservative, in that I did not remove any of the code in the XML parser that "upgraded" certain types of old parts to their newer variants. I wasn't quite sure what versions they came from so I erred on the side of safety. Once 0.48 lands I'll work to remove those as well.
Going forward, I believe the strategy offered by @neoancient should be adopted: we support upgrading from the N-1 stable version. That would capture all of the relevant upgrades without much of a burden for folks lagging behind (for whatever reason).