-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHQ Colours: Adding Customizability as part of MHQ Options #2284
MHQ Colours: Adding Customizability as part of MHQ Options #2284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
============================================
- Coverage 10.56% 10.55% -0.02%
- Complexity 3540 3546 +6
============================================
Files 670 668 -2
Lines 94674 94887 +213
Branches 15859 15857 -2
============================================
+ Hits 10007 10013 +6
- Misses 83291 83503 +212
+ Partials 1376 1371 -5
Continue to review full report at Codecov.
|
@NickAragua is there a reason other than style differences that this is still open? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, probably won't make much of a difference either way. Let 'er rip.
This PR moves MHQ Colours to instead be part of the MHQ Options, and lets one customize the options. This requires MegaMek/megamek#2508.