Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHQ Colours: Adding Customizability as part of MHQ Options #2284

Merged
merged 12 commits into from
May 31, 2021

Conversation

Windchild292
Copy link
Contributor

This PR moves MHQ Colours to instead be part of the MHQ Options, and lets one customize the options. This requires MegaMek/megamek#2508.

@Windchild292 Windchild292 added (RFE) Enhancement Requests for Enhancement, new features or implementations Accessibility Work dealing with improving the accessibility of the application GUI labels Dec 13, 2020
@Windchild292 Windchild292 self-assigned this Dec 13, 2020
@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #2284 (872718a) into master (05495f4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2284      +/-   ##
============================================
- Coverage     10.56%   10.55%   -0.02%     
- Complexity     3540     3546       +6     
============================================
  Files           670      668       -2     
  Lines         94674    94887     +213     
  Branches      15859    15857       -2     
============================================
+ Hits          10007    10013       +6     
- Misses        83291    83503     +212     
+ Partials       1376     1371       -5     
Impacted Files Coverage Δ Complexity Δ
MekHQ/src/mekhq/MekHQOptions.java 3.20% <0.00%> (-4.38%) 6.00 <0.00> (ø)
MekHQ/src/mekhq/MekHqConstants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/ForceRenderer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/dialog/MekHqOptionsDialog.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/model/LoanTableModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/model/PersonnelTableModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ekHQ/src/mekhq/gui/model/RetirementTableModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/model/UnitTableModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/view/LanceAssignmentView.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/campaign/universe/Systems.java 41.43% <0.00%> (-0.80%) 35.00% <0.00%> (-1.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05495f4...872718a. Read the comment docs.

@Windchild292 Windchild292 modified the milestone: 0.48-stable Dec 13, 2020
@Windchild292 Windchild292 added this to the 0.49-dev milestone Dec 31, 2020
MekHQ/src/mekhq/MekHQOptions.java Show resolved Hide resolved
MekHQ/src/mekhq/MekHQOptions.java Show resolved Hide resolved
MekHQ/src/mekhq/MekHQOptions.java Show resolved Hide resolved
MekHQ/src/mekhq/MekHQOptions.java Show resolved Hide resolved
MekHQ/src/mekhq/MekHQOptions.java Show resolved Hide resolved
MekHQ/src/mekhq/MekHQOptions.java Show resolved Hide resolved
@Windchild292 Windchild292 requested a review from NickAragua March 10, 2021 02:30
@Windchild292
Copy link
Contributor Author

@NickAragua is there a reason other than style differences that this is still open?

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, probably won't make much of a difference either way. Let 'er rip.

@Windchild292 Windchild292 merged commit 4d658cb into MegaMek:master May 31, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_MHQColours branch May 31, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Work dealing with improving the accessibility of the application GUI (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants