-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MissionStatus Enum #2151
MissionStatus Enum #2151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, looks fine otherwise.
Codecov Report
@@ Coverage Diff @@
## master #2151 +/- ##
============================================
+ Coverage 10.34% 10.36% +0.01%
- Complexity 3417 3432 +15
============================================
Files 674 675 +1
Lines 94621 94574 -47
Branches 15906 15870 -36
============================================
+ Hits 9788 9801 +13
+ Misses 83468 83399 -69
- Partials 1365 1374 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor potential code changes, good to go otherwise.
Fixed both issues and have now pushed the changes |
This PR swaps MissionStatus from magic numbers to an enum.
As part of this I reworked the CompleteMissionDialog, which is the first commit.