Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.49.13] Wrong Quality names in Set Quality GM Menu after selecting reverse quality names in campaign settings. #3763

Closed
TheArtofFencing opened this issue Sep 23, 2023 · 1 comment · Fixed by #3824
Closed

[0.49.13] Wrong Quality names in Set Quality GM Menu after selecting reverse quality names in campaign settings. #3763

TheArtofFencing opened this issue Sep 23, 2023 · 1 comment · Fixed by #3824

Comments

@TheArtofFencing
Copy link

Environment
[0.49.13] Mac Java Version: 16.0.2

Description

While having reversed Quality unit parts on, manually setting them in GM mode shows the standard quality names. So setting a unit to quality F set it to A and accordantly for the other qualities. In the picture you can se the default sorting of the GM mode menu which has F as the highest, which equals to the highest quality set.

image
Quality names GM Mode wrong.cpnx.gz
@TheArtofFencing
Copy link
Author

After testing: Bug still present in [0.49.14]

jackreichelt added a commit to jackreichelt/mekhq that referenced this issue Jan 30, 2024
@jackreichelt
MegaMek#3763 reversing quality names in unit set quality GM menu
959c445
@jackreichelt jackreichelt mentioned this issue Jan 30, 2024
Merged
HammerGS added a commit that referenced this issue Feb 4, 2024
@HammerGS
Merge pull request #3824 from jackreichelt/#3763-set-quality-reversing
3afc62f 
#3763 reversing quality names in unit set quality GM menu
HammerGS added a commit that referenced this issue Feb 4, 2024
@HammerGS
Merging PR's
880d3f4 
+ PR #3821: Add max contract salvage percentage to campaign options

+ Fix #3763: Reversing quality names in unit set quality GM menu

+ FIx #3194: Awarding non-stackable medals to multiple people
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3763 reversing quality names in unit set quality GM menu jackreichelt/mekhq
1 participant
@TheArtofFencing