Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

47.13 Cannot Refit #2219

Closed
Flibjib opened this issue Nov 10, 2020 · 2 comments · Fixed by #2218
Closed

47.13 Cannot Refit #2219

Flibjib opened this issue Nov 10, 2020 · 2 comments · Fixed by #2218
Assignees
@sixlettervariables
Labels
Bug

Comments

@Flibjib
Copy link

Flibjib commented Nov 10, 2020

47.13
Cannot refit units, window fails to appear for refit kit selection.

Cavaliere Ghiottone30550103.cpnx.gz
megameklog.txt
mekhqlog.txt
@sixlettervariables sixlettervariables self-assigned this Nov 10, 2020
@sixlettervariables
Copy link
Contributor

sixlettervariables commented Nov 10, 2020 •
edited
Loading

Should be handled by #2218, but I'll double check. Apologies for breaking these releases hard!
Relevant exception from the log:

java.lang.NullPointerException
	at mekhq.campaign.parts.MissingPart.findReplacement(MissingPart.java:167)
	at mekhq.campaign.parts.Refit.calculate(Refit.java:511)
	at mekhq.campaign.parts.Refit.<init>(Refit.java:179)
	at mekhq.gui.dialog.ChooseRefitDialog.populateRefits(ChooseRefitDialog.java:297)
	at

@sixlettervariables sixlettervariables mentioned this issue Nov 10, 2020
Merged
sixlettervariables added a commit that referenced this issue Nov 10, 2020
@sixlettervariables
Merge pull request #2218 from sixlettervariables/issue-2217-refit-npe
aa3ea9e 
Issues #2217 #2219: Cannot save Campaign with Refits and cannot start new Refits
@sixlettervariables
Copy link
Contributor

Tests covering this bug are in #2224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sixlettervariables sixlettervariables

Labels
Bug
Projects
None yet
Milestone
No milestone
2 participants
@sixlettervariables @Flibjib