code review changes

MegaMek · Aug 13, 2021 · a4e9daf · a4e9daf
1 parent 3dcdb3c
commit a4e9daf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml b/MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml
@@ -1,6 +1,6 @@
 <AtBScenarioModifier>
 	<additionalBriefingText>Local coordination has allowed the opposition to deploy a larger force to respond to your presence.</additionalBriefingText>
-	<benefitsPlayer>fakse</benefitsPlayer>
+	<benefitsPlayer>false</benefitsPlayer>
 	<eventTiming>PreForceGeneration</eventTiming>
 	<eventRecipient>Opposing</eventRecipient>
 	<bvBudgetAdditiveMultiplier>-1</bvBudgetAdditiveMultiplier>

diff --git a/MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java b/MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java
@@ -1943,8 +1943,8 @@ private static void setDeploymentTurns(AtBDynamicScenario scenario) {
 
     /**
      * Sets up deployment turns for all bot units within the specified bot force according to the specified force template's rules.
-     * @param botForce The bot force to process
-     * @param deployRound The specific deployment round, or a special constant.
+     * Also makes use of the given scenarios reinforcement delay modifier.
+     * 
      * ARRIVAL_TURN_STAGGERED_BY_LANCE is not implemented.
      * ARRIVAL_TURN_STAGGERED is processed just prior to scenario start instead (?)
      */

diff --git a/MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java b/MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java
@@ -408,13 +408,7 @@ public void failObjective(StratconCoords coords) {
      * Whether or not this track has a facility on it that reveals the track.
      */
     public boolean hasActiveTrackReveal() {
-        for (StratconFacility facility : getFacilities().values()) {
-            if (facility.getRevealTrack()) {
-                return true;
-            }
-        }
-
-        return false;
+        return getFacilities().values().stream().anyMatch(facility -> facility.getRevealTrack());
     }
 
     /**