Merge pull request #5773 from IllianiCBT/resupply_warehouseShenanigans

Log Prohibited Unit Skips in Resupplies & Prevent Invalid Part Additions
MegaMek · Jan 15, 2025 · 778679b · 778679b
2 parents a2a95c3 + 695e34d
commit 778679b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/MekHQ/src/mekhq/campaign/mission/resupplyAndCaches/Resupply.java b/MekHQ/src/mekhq/campaign/mission/resupplyAndCaches/Resupply.java
@@ -543,6 +543,7 @@ private Map<String, PartDetails> collectParts() {
                 }
 
                 if (isProhibitedUnitType(entity, false)) {
+                    logger.info("skipping " + unit.getName() + " as it is prohibited.");
                     continue;
                 }
 
@@ -727,8 +728,12 @@ private void applyWarehouseWeightModifiers(Map<String, PartDetails> partsList) {
                 continue;
             }
 
-            PartDetails partDetails = new PartDetails(part, weight);
+            // This prevents us accidentally adding new items to the pool
+            if (!partsList.containsKey(getPartKey(part))) {
+                continue;
+            }
 
+            PartDetails partDetails = new PartDetails(part, weight);
             partsList.merge(getPartKey(part), partDetails, (oldValue, newValue) -> {
                 oldValue.setWeight(oldValue.getWeight() - newValue.getWeight());
                 return oldValue;