Fixed NPE in Mass Enroll Filters

Refactored the filtering logic to improve readability and consistency by using `Objects.equals` for comparison and added a null check with `Objects::nonNull`.
MegaMek · Aug 2, 2024 · 1b488c6 · 1b488c6
1 parent 76e9cea
commit 1b488c6
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java b/MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java
@@ -3007,8 +3007,13 @@ private void buildEducationMenusMassEnroll(Campaign campaign, List<Person> perso
                 // find the first faction that accepts applications from all persons in personnel
                 Optional<String> suitableFaction = personnel.stream()
                         .map(person -> academy.getFilteredFaction(campaign, person, campaign.getCurrentSystem().getFactions(campaign.getLocalDate())))
-                        .filter(faction -> personnel.stream().allMatch(person -> faction.equals(academy.getFilteredFaction(campaign, person, campaign.getCurrentSystem().getFactions(campaign.getLocalDate())))))
+                        .filter(faction -> personnel.stream().allMatch(person ->
+                                Objects.equals(
+                                        faction,
+                                        academy.getFilteredFaction(campaign, person, campaign.getCurrentSystem().getFactions(campaign.getLocalDate()))
+                                )))
                         .distinct()
+                        .filter(Objects::nonNull)
                         .findFirst();
 
                 if (suitableFaction.isPresent()) {